-
Notifications
You must be signed in to change notification settings - Fork 82
Add ESP32 board to "Compile Examples" CI workflow #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@aentinger I see that ESP32 support was added to the Arduino_ConnectionHandler library (arduino-libraries/Arduino_ConnectionHandler#47) since the time of the last release. Do you want me to adjust the "Compile Examples" workflow to use the development version of Arduino_ConnectionHandler from the tip of the repository's |
Memory usage change @ 1dadd4b
Click for full report table
Click for full report CSV
|
@per1234 please use the release version for now. If the CI build on Arduino_ConnectionHandler checks out then we can move forward with this PR. |
ESP32 support has been added to the library, so the examples compilation smoke test should be done for this architecture as well.
…the reason for this behaviour shall be investigated in the near future).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @per1234 🚀 Let's wait a good CI build with the Arduino_ConnectionHandler:0.6.0 (should be picked up by library manager in the next couple of hours) and then we should be good to merge 👍
ESP32 support has been added to the library (#211), so the examples compilation smoke test should be done for this architecture as well.
Fixes #215