Skip to content

GenericConnectionhandler redesign of internal structures #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andreagilardoni
Copy link
Contributor

@andreagilardoni andreagilardoni commented Apr 3, 2025

The objective of this PR is to make the implementation of the various connection handler more generic.

with this change it was possible to create a GenericConnection handler that is able to be instantiated in conditions where the kind of connection has to be decided at runtime.

Testing connection handler

mbed core f7ff4114bc0d89f23b45423e049f5bc17114dcbc
renesas core 84d44b8f42bb657d66aa8fdda66f789f294dfddd
samd core 993398cb7a23a4e0f821a73501ae98053773165b

Board Name Demo PHY
arduino:esp32:nano_nora OK WiFI
arduino:mbed_giga:giga OK WiFI
arduino:mbed_nano:nanorp2040connect OK WiFI
arduino:mbed_nicla:nicla_vision OK WiFI
arduino:mbed_opta:opta OK WiFI
arduino:mbed_opta:opta OK Eth
arduino:mbed_portenta:envie_m7 OK WiFi
arduino:mbed_portenta:envie_m7 OK Eth
arduino:renesas_uno:unor4wifi OK WiFi
arduino:samd:mkrwifi1010 OK WiFi
arduino:samd:nano_33_iot OK WiFi

@andreagilardoni andreagilardoni changed the title Connectionhandler settings Connectionhandler redesign of internal structures Apr 3, 2025

This comment was marked as outdated.

This comment was marked as outdated.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Apr 7, 2025
@andreagilardoni andreagilardoni force-pushed the connectionhandler-settings branch from 5f9c616 to f4fd222 Compare April 9, 2025 07:35

This comment was marked as outdated.

This comment was marked as outdated.

@andreagilardoni andreagilardoni force-pushed the connectionhandler-settings branch 2 times, most recently from f674482 to 9dc0fe5 Compare April 10, 2025 12:41
@andreagilardoni andreagilardoni marked this pull request as ready for review April 10, 2025 12:48

This comment was marked as outdated.

@andreagilardoni andreagilardoni force-pushed the connectionhandler-settings branch from 9dc0fe5 to f34627d Compare April 17, 2025 08:31

This comment was marked as outdated.

@andreagilardoni andreagilardoni force-pushed the connectionhandler-settings branch from f34627d to de0a36d Compare May 7, 2025 09:22
@andreagilardoni andreagilardoni force-pushed the connectionhandler-settings branch from de0a36d to 2760757 Compare May 7, 2025 11:57
Copy link

github-actions bot commented May 7, 2025

Memory usage change @ 2760757

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 +492 - +776 +0.02 - +0.02 🔺 +8 - +96 0.0 - +0.03
arduino:mbed:envie_m7 N/A N/A N/A N/A
arduino:mbed_edge:edge_control 🔺 +144 - +272 +0.01 - +0.03 🔺 +8 - +224 0.0 - +0.09
arduino:mbed_giga:giga 🔺 +144 - +208 +0.01 - +0.01 🔺 +8 - +96 0.0 - +0.02
arduino:mbed_nano:nanorp2040connect 🔺 +170 - +362 0.0 - 0.0 🔺 +8 - +96 0.0 - +0.04
arduino:mbed_nicla:nicla_vision 🔺 +208 - +208 +0.01 - +0.01 🔺 +8 - +96 0.0 - +0.02
arduino:mbed_opta:opta 🔺 +144 - +272 +0.01 - +0.01 🔺 0 - +8 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 +176 - +280 +0.01 - +0.01 🔺 +8 - +128 0.0 - +0.02
arduino:renesas_uno:unor4wifi 🔺 +176 - +264 +0.07 - +0.1 🔺 +8 - +96 +0.02 - +0.29
arduino:samd:mkr1000 🔺 +176 - +264 +0.07 - +0.1 🔺 +8 - +96 +0.02 - +0.29
arduino:samd:mkrgsm1400 🔺 +176 - +312 +0.07 - +0.12 🔺 +8 - +228 +0.02 - +0.7
arduino:samd:mkrnb1500 🔺 +176 - +304 +0.07 - +0.12 🔺 +8 - +228 +0.02 - +0.7
arduino:samd:mkrwan1300 🔺 +176 - +256 +0.07 - +0.1 🔺 +8 - +52 +0.02 - +0.16
arduino:samd:mkrwan1310 🔺 +168 - +256 +0.06 - +0.1 🔺 +8 - +52 +0.02 - +0.16
arduino:samd:mkrwifi1010 🔺 +176 - +264 +0.07 - +0.1 🔺 +8 - +96 +0.02 - +0.29
arduino:samd:nano_33_iot 🔺 +168 - +264 +0.06 - +0.1 🔺 +8 - +96 +0.02 - +0.29
esp32:esp32:esp32 🔺 +492 - +712 +0.04 - +0.05 🔺 +8 - +96 0.0 - +0.03
esp8266:esp8266:huzzah 🔺 +368 - +368 +0.04 - +0.04 🔺 +96 - +96 +0.12 - +0.12
rp2040:rp2040:rpipicow 🔺 +336 - +392 +0.02 - +0.02 🔺 +24 - +96 +0.01 - +0.04
Click for full report table
Board examples/ConnectionHandlerDemo
flash
% examples/ConnectionHandlerDemo
RAM for global variables
% examples/ConnectionHandlerDemo-Notecard
flash
% examples/ConnectionHandlerDemo-Notecard
RAM for global variables
%
arduino:esp32:nano_nora 776 0.02 96 0.03 492 0.02 8 0.0
arduino:mbed:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_edge:edge_control 272 0.03 224 0.09 144 0.01 8 0.0
arduino:mbed_giga:giga 208 0.01 96 0.02 144 0.01 8 0.0
arduino:mbed_nano:nanorp2040connect 362 0.0 96 0.04 170 0.0 8 0.0
arduino:mbed_nicla:nicla_vision 208 0.01 96 0.02 208 0.01 8 0.0
arduino:mbed_opta:opta 272 0.01 0 0.0 144 0.01 8 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 280 0.01 128 0.02 176 0.01 8 0.0
arduino:renesas_uno:unor4wifi 264 0.1 96 0.29 176 0.07 8 0.02
arduino:samd:mkr1000 264 0.1 96 0.29 176 0.07 8 0.02
arduino:samd:mkrgsm1400 312 0.12 228 0.7 176 0.07 8 0.02
arduino:samd:mkrnb1500 304 0.12 228 0.7 176 0.07 8 0.02
arduino:samd:mkrwan1300 256 0.1 52 0.16 176 0.07 8 0.02
arduino:samd:mkrwan1310 256 0.1 52 0.16 168 0.06 8 0.02
arduino:samd:mkrwifi1010 264 0.1 96 0.29 176 0.07 8 0.02
arduino:samd:nano_33_iot 264 0.1 96 0.29 168 0.06 8 0.02
esp32:esp32:esp32 712 0.05 96 0.03 492 0.04 8 0.0
esp8266:esp8266:huzzah 368 0.04 96 0.12
rp2040:rp2040:rpipicow 336 0.02 96 0.04 392 0.02 24 0.01
Click for full report CSV
Board,examples/ConnectionHandlerDemo<br>flash,%,examples/ConnectionHandlerDemo<br>RAM for global variables,%,examples/ConnectionHandlerDemo-Notecard<br>flash,%,examples/ConnectionHandlerDemo-Notecard<br>RAM for global variables,%
arduino:esp32:nano_nora,776,0.02,96,0.03,492,0.02,8,0.0
arduino:mbed:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_edge:edge_control,272,0.03,224,0.09,144,0.01,8,0.0
arduino:mbed_giga:giga,208,0.01,96,0.02,144,0.01,8,0.0
arduino:mbed_nano:nanorp2040connect,362,0.0,96,0.04,170,0.0,8,0.0
arduino:mbed_nicla:nicla_vision,208,0.01,96,0.02,208,0.01,8,0.0
arduino:mbed_opta:opta,272,0.01,0,0.0,144,0.01,8,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,280,0.01,128,0.02,176,0.01,8,0.0
arduino:renesas_uno:unor4wifi,264,0.1,96,0.29,176,0.07,8,0.02
arduino:samd:mkr1000,264,0.1,96,0.29,176,0.07,8,0.02
arduino:samd:mkrgsm1400,312,0.12,228,0.7,176,0.07,8,0.02
arduino:samd:mkrnb1500,304,0.12,228,0.7,176,0.07,8,0.02
arduino:samd:mkrwan1300,256,0.1,52,0.16,176,0.07,8,0.02
arduino:samd:mkrwan1310,256,0.1,52,0.16,168,0.06,8,0.02
arduino:samd:mkrwifi1010,264,0.1,96,0.29,176,0.07,8,0.02
arduino:samd:nano_33_iot,264,0.1,96,0.29,168,0.06,8,0.02
esp32:esp32:esp32,712,0.05,96,0.03,492,0.04,8,0.0
esp8266:esp8266:huzzah,368,0.04,96,0.12,,,,
rp2040:rp2040:rpipicow,336,0.02,96,0.04,392,0.02,24,0.01

@pennam pennam changed the title Connectionhandler redesign of internal structures GenericConnectionhandler redesign of internal structures May 7, 2025
@pennam pennam merged commit 0786d7a into arduino-libraries:master May 7, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants