Skip to content

Fix SIM not present bug #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2020
Merged

Fix SIM not present bug #20

merged 1 commit into from
Jan 29, 2020

Conversation

luigigubello
Copy link
Contributor

Removing while(1); to exit from the loop. Editing CHECK_INTERVAL_RETRYING value.
/CC @Rocketct

Fix SIM not present bug
10f0637 
Removing while(1) to block the error message loop. Editing CHECK_INTERVAL_RETRYING
value.
@Rocketct
Copy link

to me seems ok

@gvarisco gvarisco self-requested a review January 29, 2020 10:16
gvarisco
gvarisco approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@gvarisco gvarisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's just monitor if CHECK_INTERVAL_RETRYING set to 30000 is enough.

@facchinm facchinm merged commit a4d3d31 into arduino-libraries:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gvarisco gvarisco gvarisco approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luigigubello @Rocketct @gvarisco @facchinm