Skip to content

Return the connection state directly when calling function check() #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 5, 2020

Conversation

aentinger
Copy link
Contributor

@aentinger aentinger commented Mar 4, 2020

  • Remove deprecated function update() - use check() instead.
  • Return current NetworkConnectionState when calling check
  • Marking getStatus as deprecated since NetworkConnectionState is returned via check
  • Removing classes TcpIpConnectionHandler/LPWANConnectionHandler since they don't provide any value and just add confusion.

@aentinger aentinger force-pushed the return-network-state-in-check-method branch from b9d58b0 to 5bc4a96 Compare March 4, 2020 07:23
@aentinger aentinger force-pushed the return-network-state-in-check-method branch from 5bc4a96 to 8ec88e0 Compare March 4, 2020 07:24
…eliminates the need to query the member variable NetConnectionStatus via 'getStatus()'
…ctly obtained from the check function and will be removed in a future version
@aentinger aentinger force-pushed the return-network-state-in-check-method branch from 0f92717 to fa7446d Compare March 4, 2020 08:11
@aentinger
Copy link
Contributor Author

Successfully tested on PROD with:

  • MKR WiFi 1010 ✔️
  • MKR GSM 1400 ✔️
  • MKR WAN 1310 ✔️
  • ESP8266 ✔️

@aentinger aentinger merged commit 6a87f58 into master Mar 5, 2020
@aentinger aentinger deleted the return-network-state-in-check-method branch March 5, 2020 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants