Skip to content

Bugfix: Don't break MKRGSM stack when ping fails. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2020
Merged

Bugfix: Don't break MKRGSM stack when ping fails. #36

merged 2 commits into from
Jul 23, 2020

Conversation

aentinger
Copy link
Contributor

@aentinger aentinger commented Jul 22, 2020 •
edited
Loading

Calling attachGPRS multiple times is not handled well by the MRK GSM/MKR GSM stack. But this is exactly what happens when the first call to ping fails. Consequently the attachGPRS part has been moved one state up so it will be only called once.

aentinger added 2 commits July 22, 2020 14:48
@aentinger
Workaround: Calling attachGPRS multiple times is not handled well by …
a20afc8 
…the MRKGSM stack. But this is exactly what happens when the first call to ping fails. Consequently the attachGPRS part has been moved one state up so it will be only called once.
@aentinger
Restructuring control flow for better readability
21825b4
@aentinger aentinger added the type: imperfection Perceived defect in any part of project label Jul 22, 2020
@aentinger aentinger self-assigned this Jul 22, 2020
@github-actions
Copy link

Memory usage change @ 21825b4

Board flash RAM for global variables
arduino:samd:mkr1000 0 - 0 0 - 0
arduino:samd:mkrgsm1400 💚 -8 - -8 0 - 0
arduino:samd:mkrnb1500 0 - 0 0 - 0
arduino:samd:mkrwan1300 0 - 0 0 - 0
arduino:samd:mkrwan1310 0 - 0 0 - 0
arduino:samd:mkrwifi1010 0 - 0 0 - 0
arduino:samd:nano_33_iot 0 - 0 0 - 0
esp8266:esp8266:huzzah 0 - 0 0 - 0
Click for full report table
Board examples/ConnectionHandlerDemo
flash		 examples/ConnectionHandlerDemo
RAM for global variables
arduino:samd:mkr1000 0 0
arduino:samd:mkrgsm1400 -8 0
arduino:samd:mkrnb1500 0 0
arduino:samd:mkrwan1300 0 0
arduino:samd:mkrwan1310 0 0
arduino:samd:mkrwifi1010 0 0
arduino:samd:nano_33_iot 0 0
esp8266:esp8266:huzzah 0 0
Click for full report CSV 
Board,examples/ConnectionHandlerDemo<br>flash,examples/ConnectionHandlerDemo<br>RAM for global variables
arduino:samd:mkr1000,0,0
arduino:samd:mkrgsm1400,-8,0
arduino:samd:mkrnb1500,0,0
arduino:samd:mkrwan1300,0,0
arduino:samd:mkrwan1310,0,0
arduino:samd:mkrwifi1010,0,0
arduino:samd:nano_33_iot,0,0
esp8266:esp8266:huzzah,0,0

@aentinger aentinger merged commit 13e490d into master Jul 23, 2020
@aentinger aentinger deleted the fix-gsm-when-ping-broken branch July 23, 2020 07:11
@aentinger aentinger mentioned this pull request Jul 29, 2020
Closed
@per1234 per1234 added the topic: code Related to content of the project itself label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aentinger aentinger

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aentinger @per1234