Update CI workflow to correctly install ArduinoCore-API in arduino:mbed core #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The symlink for ArduinoCore-API in the Mbed OS Boards core library has been removed. This resulted in the step of the "Compile Examples" CI workflow that removes the now non-existent symlink to fail.
Previously, the `namespace_arduino` branch of `arduino/ArduinoCore-API` was used in the core library of the development version of the Mbed OS Boards platform used in the "Compile Examples" CI workflow. The default branch of `arduino/ArduinoCore-API` is now the latest and greatest version, so the `namespace_arduino` branch should no longer be used for the Mbed OS Boards platform's core library.
|
Memory usage change @ 3b0e185
Click for full report table
Click for full report CSV |
aentinger
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to the Arduino Mbed OS Boards platform core's handling of the
arduino/ArduinoCore-APIrepository resulted in the need to adjus how the "Compile Examples" CI workflow installs it for those boards.The symlink for ArduinoCore-API in the Mbed OS Boards core library has been removed (arduino/ArduinoCore-mbed@ca397e8). This resulted in the step of the "Compile Examples" CI workflow that removes the now non-existent symlink to fail.
Previously, the
namespace_arduinobranch of ArduinoCore-API was used in the core library of the development version ofthe Mbed OS Boards platform used in the "Compile Examples" CI workflow. The default branch of ArduinoCore-API is now the
latest and greatest version, so the
namespace_arduinobranch should no longer be used for the Mbed OS Boards platform's core library (arduino/ArduinoCore-mbed@3c175d7).