Skip to content

address issues 139 and 141 #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

address issues 139 and 141 #142

wants to merge 1 commit into from
+14 −3

Conversation

rayshobby
Copy link

@rayshobby rayshobby commented Jul 25, 2020 •
edited by per1234
Loading

This pull request resolves #139 (setSS on ESP8266) and resolves #141 (EthernetClient::write).

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Nov 23, 2023
@per1234 per1234 mentioned this pull request Nov 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@d-a-v d-a-v d-a-v approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EthernetClient::write returns wrong value when buffer size exceeds W5100.SSIZE On ESP8266, setSS() does not work when using GPIO16 as CS pin
4 participants
@rayshobby @CLAassistant @d-a-v @per1234