Update for newer avr-gcc. (solves https://github.com/arduino/Arduino/issues/1807)

[HeMan]

• Newer avr-gcc doesn't use -assembler-with-cpp, but
  uses -x assembler-with-cpp.

[matthijskooijman]

Cool!

Just for github's convenience, I'll repeat that this fixed #1807, since it seems it didn't pick up the link in the title.

Regarding the actual commit, it looks good to me. Two remarks, though:

• The commit message is a bit backwards. Better start with what actually changed ("Compile assembly with -x assembler-with-cpp instead of -assembler-with-cpp" and then in the longer description say that this makes things work with newer avr-gcc versions. You should probably also mention that the -x version also works with older avr-gcc versions.
• This fixes the problem on the 1.0.x branch, but not the 1.5.x branch (which will need updating hardware/arduino/avr/platform.txt instead). Perhaps you could fix that one too (best done in a separate commit).

If you want to change this pullrequest, you can just locally apply the changes (e.g., using git commit --amend to change the commit message for example) and then do a force push to the branch in your fork, github will automatically update the commits in this pullrequest then.

Thanks for working on this!

[HeMan]

On 2014-01-21 20:47, Matthijs Kooijman wrote:

Cool!

Just for github's convenience, I'll repeat that this fixed #1807
#1807, since it seems it
didn't pick up the link in the title.

Regarding the actual commit, it looks good to me. Two remarks, though:

• The commit message is a bit backwards. Better start with what
  actually changed ("Compile assembly with -x assembler-with-cpp
  instead of -assembler-with-cpp" and then in the longer description
  say that this makes things work with newer avr-gcc versions. You
  should probably also mention that the -x version also works with
  older avr-gcc versions.
• This fixes the problem on the 1.0.x branch, but not the 1.5.x branch
  (which will need updating |hardware/arduino/avr/platform.txt|
  instead). Perhaps you could fix that one too (best done in a
  separate commit).

If you want to change this pullrequest, you can just locally apply the
changes (e.g., using |git commit --amend| to change the commit message
for example) and then do a force push to the branch in your fork, github
will automatically update the commits in this pullrequest then.

Thanks for working on this!

Thanks for the response! I've updated the message with your suggestions.
Will start working on 1.5 now!

Regards,
Jimmy

—
Reply to this email directly or view it on GitHub
#1814 (comment).

[matthijskooijman]

Looking good!