Skip to content

Jira 858, Can't trigger BLEConnected, BLEDisconnected events, git 445 #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Jira 858, Can't trigger BLEConnected, BLEDisconnected events, git 445 #455

wants to merge 1 commit into from

Conversation

SidLeung
Copy link
Contributor

Root casue:

  • The callback regiter before the begin and the begin
    reset the callback.

Code mods:

  1. BLEPeripheral.cpp:
    • Remove clearing of callback register array at begin(). The
      array is cleared upon system initialization.

@SidLeung SidLeung self-assigned this Feb 23, 2017
@SidLeung SidLeung added this to the Deneb milestone Feb 23, 2017
@SidLeung
Copy link
Contributor Author

This PR originates from one segment of #447 to address Jira 858 (git issue 445).

@eriknyquist , Made the changes you requested in #447, please review.

@russmcinnis @noelpaz , please re-test this item since there is code change involved since the last round. Thanks.

@SidLeung SidLeung mentioned this pull request Feb 23, 2017
Closed
russmcinnis
russmcinnis approved these changes Feb 28, 2017
View reviewed changes
Copy link
Contributor

@russmcinnis russmcinnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

system tests and unit tests passed. Connect and Disconnect events are logged in the serial console as expected.

@sgbihu @SidLeung
Jira 858, Can't trigger BLEConnected, BLEDisconnected events, git 445
7866b1f 
Root casue:
  - The callback regiter before the begin and the begin
    reset the callback.

Code mods:
1. BLEPeripheral.cpp:
   - Remove clearing of callback register array at begin(). The
     array is cleared upon system initialization.
@SidLeung
Copy link
Contributor Author

SidLeung commented Mar 1, 2017

@yashaswini-hanji , please merge this PR to main trunk and close the Jira ticket

@SidLeung SidLeung assigned yashaswini-hanji and unassigned SidLeung Mar 1, 2017
@yashaswini-hanji
Copy link
Contributor

PR merged and Jira closed

@yashaswini-hanji yashaswini-hanji removed their assignment Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriknyquist eriknyquist eriknyquist approved these changes

@russmcinnis russmcinnis russmcinnis approved these changes

@bigdinotech bigdinotech Awaiting requested review from bigdinotech

@noelpaz noelpaz Awaiting requested review from noelpaz

@dcleri dcleri Awaiting requested review from dcleri

Assignees
No one assigned
Labels
bug Under Review
Projects
None yet
Milestone
Deneb
Development

Successfully merging this pull request may close these issues.
5 participants
@SidLeung @yashaswini-hanji @eriknyquist @russmcinnis @sgbihu