-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update new.cpp #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update new.cpp #564
Conversation
Suppress 4 annoying warnings in new.cpp.
Memory usage change @ 0a14a50
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to submit this fix @jmparatte. I see we already have a pull request for this exact change (#474) so I'll close this as a duplicate.
Do you realize that there is an option in the preferences already to enable compiler warnings? It is not enabled by default, which would be good (but people were hesitant to do so, since that will also produce warnings for other people's code (libraries and cores) that a beginner user cannot really fix. |
True. It's why I have posted 4 changes in AVR new.cpp to correct the code and suppress warnings of 4 unused parameters. Simple. But warn beginners or possible miscoding is good. It isn't? |
Suppress 4 annoying warnings in new.cpp.