Skip to content
This repository was archived by the owner on Apr 1, 2022. It is now read-only.

Add pySerial to the compile-examples container #85

Closed
wants to merge 1 commit into from
Closed

Add pySerial to the compile-examples container #85

wants to merge 1 commit into from

Conversation

platisd
Copy link

@platisd platisd commented Nov 7, 2020

pySerial is needed to compile sketches for ESP32-based boards.
Without including it as a compile-examples container dependency,
it is not possible to compile Arduino sketches for a wide range of modern
boards.

@platisd
Copy link
Author

platisd commented Nov 7, 2020

I trust the error in the action that's failing is not related to my patch. :)

Version 3.8.5 with arch x64 not found
Available versions:

2.7.18 (x64)
3.5.10 (x64)
3.6.12 (x64)
3.7.9 (x64)
3.8.6 (x64)
3.9.0 (x64)

PySerial is needed to compile sketches for ESP32-based
boards. Without including it in the compile-examples
container, it is not possible to compile Arduino sketches
for a wide range of modern boards.
@per1234
Copy link
Contributor

per1234 commented Nov 9, 2020

Hi @platisd. Thanks so much for taking the time to submit a PR and for bringing this issue to our attention!

This action is in a bit of an odd transitional phase in that it has been migrated to a dedicated repository:
https://github.com/arduino/compile-sketches
and maintenance of the outdated version that remains in this repo has been halted (hence the failing test CI workflow), but we haven't made the release in the new repository that is the prequisite to the formal deprecation of the action in this repository.

The action has recently been transitioned from a Docker container to a composite run steps action. This means that the Python script runs directly in the GitHub Actions runner. That change opens up the possibility for the user to install arbitrary boards platform dependencies such as the pyserial package in their workflow in a step prior to running the action.

However, doing this with a Python package specifically was still not possible because the action runs in a venv virtual environment. The solution I found was to configure venv to use the system site packages.

I have submitted a pull request for this change:
arduino/compile-sketches#15
If you get the time, please review that PR and approve it if you agree with the change I proposed.

@platisd
Copy link
Author

platisd commented Nov 9, 2020

Sounds like an even better solution. Tried it out and it works. Closing this pull request and reviewing the other one you opened.

@platisd platisd closed this Nov 9, 2020
@per1234 per1234 added conclusion: declined Will not be worked on topic: infrastructure Related to repository infrastructure type: enhancement Proposed improvement labels Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
conclusion: declined Will not be worked on topic: infrastructure Related to repository infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants