Skip to content

Bump actions version #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 24, 2020
Merged

Bump actions version #1078

merged 9 commits into from
Nov 24, 2020

Conversation

rsora
Copy link
Contributor

@rsora rsora commented Nov 16, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?
  • What is the current behavior?
  • What is the new behavior?
  • Does this PR introduce a breaking change?
  • Other information:

See how to contribute

@rsora rsora changed the title Rsora/bump actions Bump actions version Nov 16, 2020
@silvanocerza
Fix issue with actions/checkout@v2
ae5db83 
In certain workflows we use a custom Docker image for cross-compilation,
this image is old and unmaintained so it has an old version of git and
the latest version actions/checkout doesn't support it.
This causes the action to fallback to the Github API to download the
files but that doesn't create a git repository, thus the history is lost
but goreleaser needs it to generate the changelog so it fails.

So we use the older version of the action in certain cases to avoid
this failures.
@silvanocerza silvanocerza marked this pull request as ready for review November 24, 2020 15:07
@silvanocerza silvanocerza merged commit 8d026ed into master Nov 24, 2020
@silvanocerza silvanocerza deleted the rsora/bump-actions branch November 24, 2020 15:09
@per1234 per1234 mentioned this pull request Mar 19, 2021
Merged
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement labels Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsora @silvanocerza @per1234