librariesindex: Fix nil pointer. Refs #1176

[r10r]

Let the library index return the latest known version,
if a library without a version is updated.

Signed-off-by: Ruben Jenster [email protected]

[CLAassistant]

All committers have signed the CLA.

[silvanocerza]

A small change requested. Would be great if you could add an integration test to reproduce the issue so we won't have regressions in the future.

[r10r]

A small change requested. Would be great if you could add an integration test to reproduce the issue so we won't have regressions in the future.

Sure I can - but it may take some time.
Where should the integration test go to? (Btw. have you seen the test I've added to index_test.go ?)

[silvanocerza]

Sure I can - but it may take some time.
Where should the integration test go to?

Integration tests go in the test folder in the project root, they're written in Python and call the CLI directly. There's more information in the official docs. I'd probably add tests for any command that is affected by this change, lib install and lib list for sure, I'd have to verify if there are others.
If you want I can take care of it, let me know.

(Btw. have you seen the test I've added to index_test.go ?)

Yep, that's fine for unit tests.

[r10r]

If you want I can take care of it, let me know.

Sorry, but I'm not used to Python, It'll take more time for you to review my code than to write it yourself.
Anyway it's good to know for the future. Thanks!

[silvanocerza]

Sorry, but I'm not used to Python, It'll take more time for you to review my code than to write it yourself.
Anyway it's good to know for the future. Thanks!

No worries, I'll take care of it as soon as I can, I'll notify you when closing the issue.
Anyway thanks for reporting it and providing a fix. Really appreciated. :)

[silvanocerza]

@r10r I had to cherry pick your commits to a separate branch and create a new PR #1189. It would have been problematic to merge this since it points to your fork's master branch and didn't want to put you through the hassle of creating a new PR.

You'll result as contributor anyway so don't worry about that.

The new PR is #1189, I'll close this one as soon as that is merged in.

[silvanocerza]

Closed since #1189 has been merged.

[r10r]

I'm really happy to see this merged. Thanks for your support!