Skip to content

added '.tpp' file ext to known list #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2021
Merged

added '.tpp' file ext to known list #1316

merged 3 commits into from
Jun 22, 2021

Conversation

tshcherban
Copy link
Contributor

@tshcherban tshcherban commented Jun 14, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
    This is an update for known file extensions list to support C++'s '.tpp' files.
  • What is the current behavior?
    Currently if we include a lib, which contains tpp's, from 'src' folder (within sketch dir) compiler does not copy template files, so the build is failing.
  • What is the new behavior?
    .tpp files should be copied on a verify/upload event to build temp folder along with other .cpp/.h etc.
  • Does this PR introduce a breaking change, and is
    titled accordingly?

    No, tpps will be processed normally, that should not require any changes in invocation/sketch files.
  • Other information:

See how to contribute

@CLAassistant
Copy link

CLAassistant commented Jun 14, 2021

CLA assistant check
All committers have signed the CLA.

@silvanocerza
Copy link
Contributor

After talking with @cmaglie we decided to add support for both .tpp and .ipp, I added some tests too.

@silvanocerza silvanocerza merged commit 83d71c8 into arduino:master Jun 22, 2021
@silvanocerza
Copy link
Contributor

Thanks @tshcherban. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants