[breaking] Pass user locale preference directly to i18n package #1365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user can configure their locale preference via the `locale` configuration key. This information is given priority by
the `github.com/arduino/arduino-cli/configuration` package over the automatically detected locale.
Previously, the `i18n` package got the configuration setting from the `github.com/arduino/arduino-cli/configuration`
package, but this will result in an import cycle when the `i18n` package is used to enable translation of the output
strings of the `configuration` package.
To avoid this, the caller now reads the configuration and passes the locale code to the `i18n` package via its `Init`
function:
i18n.Init("it")
The argument can be omitted if only automated locale detection is needed:
i18n.Init()
per1234
added
type: enhancement
silvanocerza
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Code restructuring
The user can configure their locale preference via the undocumented
localeconfiguration key. This information is given priority by thegithub.com/arduino/arduino-cli/configurationpackage over the automatically detected locale.Previously, the
i18npackage got the configuration setting from thegithub.com/arduino/arduino-cli/configurationpackage, but this will result in an import cycle when thei18npackage is used to enable translation of the output strings of theconfigurationpackage.To avoid this import cycle, the caller now reads the configuration and passes the locale code to the
i18npackage via theInitfunction:
The argument may be omitted if only automated locale detection is needed:
titled accordingly?
yes
yes