[skip changelog] Refactor and add TEST_LDFLAGS
to test-unit-race
and test-legacy
tasks
#1417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)The PR adds the
TEST_LDFLAGS
totest-unit-race
andtest-legacy
tasksThe task
test-unit-race
was failing in checking if the correct version parameter are passed correctly during build time here https://github.com/arduino/arduino-cli/blob/master/version/version_test.go#L29Passing now to the task commands the
TEST_LDFLAGS
, the test runs successfullytitled accordingly?
Bonus: Bumped the go version in the
go.mod
to 1.16 here c3358a0See how to contribute