Skip to content

[skip changelog] Fix integration tests on OS X #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Fixes some integration tests.

  • What is the current behavior?

Upload integration tests are failing on OS X because board list command returns also bluetooth devices.

Also some tests are failing cause they're using too old versions of esp32 platform.

  • What is the new behavior?

Boards without an FQBN are now skipped in integration tests.

We also updated the package index URL for esp32 and some platform version used for testing.

Nope.

  • Other information:

None.


See how to contribute

@silvanocerza silvanocerza requested review from per1234 and a team September 1, 2021 09:00
@silvanocerza silvanocerza self-assigned this Sep 1, 2021
@silvanocerza silvanocerza changed the title Scerza/fix darwin tests [skip changelog] Fix integration tests on OS X Sep 1, 2021
@silvanocerza silvanocerza merged commit 2c40e02 into master Sep 1, 2021
@silvanocerza silvanocerza deleted the scerza/fix-darwin-tests branch September 1, 2021 09:55
silvanocerza added a commit that referenced this pull request Sep 1, 2021
* [skip changelog] Skip boards without FQBN in tests

* [skip changelog] Fix esp32 integration test on darwin
@per1234 per1234 added topic: infrastructure Related to project infrastructure and removed topic: testing labels Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants