Skip to content

Added --debug-file flag to gRPC daemon debug mode #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2022
Merged

Added --debug-file flag to gRPC daemon debug mode #1704

merged 1 commit into from
Apr 4, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Apr 4, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
    Added --debug-file flag to the daemon command, so the CLI will output the debug logging output to a specific file (useful when the output of CLI is not visible from the IDE GUI).
  • Does this PR introduce a breaking change, and is
    titled accordingly?
    No breaking changes.

@cmaglie cmaglie self-assigned this Apr 4, 2022
@cmaglie cmaglie requested a review from a team April 4, 2022 13:52
@cmaglie cmaglie merged commit 306f195 into arduino:master Apr 4, 2022
@cmaglie cmaglie deleted the debug-grpc branch April 4, 2022 22:05
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself topic: CLI Related to the command line interface topic: gRPC Related to the gRPC interface labels Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fstasi fstasi fstasi approved these changes

Assignees

@cmaglie cmaglie

Labels
topic: CLI Related to the command line interface topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmaglie @fstasi @per1234