[breaking] Improved compile report / temporary support for profile creation #1745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
changed the title
cmaglie
added
type: enhancement
ubidefeo
reviewed
Jun 1, 2022
ubidefeo
reviewed
Jun 1, 2022
It will be probably deprecated and removed once a better UX is implemented.
cmaglie
force-pushed
the
compilation_report
branch
from
0e524e7 to
25e6df5
Compare
umbynos
reviewed
Jun 1, 2022
umbynos
approved these changes
Jun 1, 2022
cmaglie
force-pushed
the
compilation_report
branch
from
84aa1ff to
df09be2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
compileflag--profile-dump: it generates a profile snippet to be copy/pasted insketch.yaml. It can be used to bootstrap profile usage starting from a standard Arduino sketch. This flag is a temporary workaround and it will be deprecated/removed once proper commands for managing profiles are implemented.Here a screenshot for both:
Does this PR introduce a breaking change, and is titled accordingly](https://arduino.github.io/arduino-cli/latest/CONTRIBUTING/#breaking)?
Yes, gRPC
CompileResponsestructure has changed. More info in theUPGRANDING.mddoc.