Skip to content

legacy: Make a lot of Builder internals private #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 21, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 18, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

It made most of the builder internals private. It will allow future refactorings without worrying about breaking changes in the golang API.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie self-assigned this Sep 18, 2023
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Sep 18, 2023
@alessio-perugini
Copy link
Contributor

Some tests are failing

@cmaglie cmaglie force-pushed the making_builder_internal branch from 41e1f49 to 873d1d3 Compare September 20, 2023 12:45
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 76.47% and no project coverage change.

Comparison is base (0e6133f) 63.03% compared to head (873d1d3) 63.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2325   +/-   ##
=======================================
  Coverage   63.03%   63.04%           
=======================================
  Files         201      201           
  Lines       19264    19260    -4     
=======================================
- Hits        12143    12142    -1     
+ Misses       6067     6065    -2     
+ Partials     1054     1053    -1     
Flag Coverage Δ
unit 63.04% <76.47%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
arduino/builder/core.go 73.84% <ø> (ø)
arduino/builder/export_cmake.go 7.98% <ø> (ø)
arduino/builder/internal/compilation/database.go 66.66% <ø> (ø)
arduino/builder/internal/detector/detector.go 74.34% <ø> (ø)
arduino/builder/internal/logger/logger.go 85.00% <ø> (ø)
...lder/internal/preprocessor/arduino_preprocessor.go 0.00% <ø> (ø)
arduino/builder/internal/preprocessor/ctags.go 68.62% <ø> (ø)
arduino/builder/internal/preprocessor/gcc.go 79.54% <ø> (ø)
...al/preprocessor/internal/ctags/ctags_has_issues.go 98.58% <ø> (ø)
...ternal/preprocessor/internal/ctags/ctags_parser.go 98.01% <ø> (ø)
... and 12 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit dde3064 into arduino:master Sep 21, 2023
@cmaglie cmaglie deleted the making_builder_internal branch September 21, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants