Try harder to not recompile sketch without modifications. #2961
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Improves the checks made to the sketch to avoid useless recompilation and preprocessing.
What is the current behavior?
The sketch source code, before being compiled, undergoes a two-phase processing:
Previously, these two operations were always performed, touching the final
sketch.cpp
. This resulted insketch.cpp
being recompiled every time. Moreover, the library discovery cache could not be exploited because of thesketch.cpp
timestamp change.What is the new behavior?
The merged sketch file is saved in a separate
sketch.cpp.merged
file, and it is compared to the newly generated content. If they match, the already preprocessedsketch.cpp
andsketch.cpp.merged
are left untouched.This is enough for the current build system to recognize that the file is already up-to-date and skip both compilation and library discovery, which greatly improves compile times.
Does this PR introduce a breaking change, and is titled accordingly?
Unless I'm missing some convoluted case, it shouldn't.
Other information