Clean up plugglable discovery and refactor serial-discovery usage #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
commented
Aug 6, 2019
| resp := &rpc.BoardListResp{Ports: []*rpc.DetectedPort{}} | ||
| for _, disc := range commands.GetDiscoveries(req) { |
There was a problem hiding this comment.
instead of going through a dynamic loading mechanism that will always return just the serial discovery, we use it directly
rsora
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the partial work to support pluggable discovery so it can be added back later with a dedicated series of PRs.
Since
serial-discoveryis the only discoverer used at the moment, its usage is now more explicit.The API was cleaned up, removing unused parameters like the context.