Skip to content

Read upload port from sketch.json #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Conversation

manchoz
Copy link
Contributor

@manchoz manchoz commented Oct 25, 2019

If cpu.port is present in sketch.json use the specified port during the upload.

Also, saves discovered or specifed port in sketch.json during board attach.

Needs to be tested on Windows.

Please, review.

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2019

CLA assistant check
All committers have signed the CLA.

@masci masci added the status: in progress Work is in progress on this label Nov 5, 2019
@manchoz manchoz force-pushed the manchoz_upload_port branch from e6663d6 to 601f4e8 Compare March 5, 2020 18:22
@rsora rsora changed the title [WIP] Read upload port from sketch.json Read upload port from sketch.json Mar 5, 2020
@rsora rsora removed the status: in progress Work is in progress on this label Mar 5, 2020
@rsora rsora added this to the 0.10.0 milestone Mar 5, 2020
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Excellent To Me!
Thanks for contributing @manchoz !

@manchoz
Copy link
Contributor Author

manchoz commented Mar 6, 2020

You are very welcome, @rsora!

Thank you so much.

@manchoz manchoz deleted the manchoz_upload_port branch March 6, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants