Use enumeration for LibraryLocation and LibraryLayout fields in grpc API #585
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enumeration is also reused inside the
arduino
package to reduce code duplication.This kind of change IMHO improves:
string
field in grpc definition, because now is an enumeraion and not a free string: t's more clear which value it can assumeAs a side effect, after this change, the rpc definitions starts to spill inside the
arduino
package.This means that the
rpc
definitions inside the .proto files became a sort of tables-of-truth, at least for this part of the API.