Skip to content

'arduino-cli lib' command arguments are now case insensitive #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 8, 2020

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Mar 20, 2020

The globals.ParseLibraryArgs functions are now moved inside cli/lib where they seems to better fit.

cmaglie added 4 commits March 20, 2020 12:26
This should make easier to install libraries from command line.
Now the cli/lib module uses ParseLibraryReferenceArgAndAdjustCase so
the cose-insensitive argument is allowed in all lib commands.
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick!
The rest is 👍

Co-Authored-By: Roberto Sora <[email protected]>
@cmaglie cmaglie merged commit c7742fa into arduino:master Apr 8, 2020
@cmaglie cmaglie deleted the lib-args-case-insensitive branch April 8, 2020 15:23
@cmaglie cmaglie self-assigned this Apr 8, 2020
@cmaglie cmaglie added this to the 0.10.0 milestone Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants