Skip to content

[skip changelog] Replace obsolete BoardDetailsResp.GetRequiredTools() call in gRPC client example #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2020
Merged

[skip changelog] Replace obsolete BoardDetailsResp.GetRequiredTools() call in gRPC client example #685

merged 1 commit into from
May 8, 2020

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented May 6, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Replace BoardDetailsResp.GetRequiredTools() call in gRPC client example with the new equivalent method GetToolsDependencies().

# command-line-arguments
.\main.go:448:42: details.GetRequiredTools undefined (type *commands.BoardDetailsResp has no field or method GetRequiredTools)
  • What is the new behavior?

client example works.

  • Does this PR introduce a breaking change?

No

@per1234
[skip changelog] Replace obsolete BoardDetailsResp.GetRequiredTools()…
e34d46e 
… call in gRPC client example

The new equivalent method is GetToolsDependencies().
@per1234 per1234 added topic: documentation Related to documentation for the project component/gRPC labels May 6, 2020
rsora
rsora approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @per1234, we definitely need to integrate the gRPC client example in the testing CI to avoid this kind of oversight 👍

@per1234 per1234 merged commit 24edec6 into arduino:master May 8, 2020
@per1234 per1234 deleted the gettoolsdependencies branch May 13, 2020 01:48
@per1234 per1234 self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

Assignees

@per1234 per1234

Labels
topic: documentation Related to documentation for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@per1234 @rsora