Skip to content

[skip changelog] Use local path for github.com/arduino/arduino-cli module dependency of docsgen #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2020
Merged

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented May 22, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Cause the command line interface documentation generation system to use the github.com/arduino/arduino-cli module from the local path.

  • What is the current behavior?

As reported in #714, previously, the generated documentation for the command line interface did not reflect recent development work. This is caused by docsgen using a pinned version of the github.com/arduino/arduino-cli module, which resulted in the the documentation only applying to the interface of the pinned version of Arduino CLI.

  • What is the new behavior?

The generated command line interface documentation will always match the code at its state when the documentation was generated.

  • Does this PR introduce a breaking change?

No.

  • Other information:

Fixes #714

Generated docs: https://per1234.github.io/arduino-cli/4.2/commands/arduino-cli/

…dule dependency of docsgen

Previously, docsgen used a pinned version of the github.com/arduino/arduino-cli module, which resulted in the generated command documentation not reflecting updates to the Arduino CLI command line interface made after the pinned version.

The new approach is to use the current version of the module from the local path, resulting in the generated documentation always matching the associated version of Arduino CLI.
@per1234 per1234 added component/CLI topic: documentation Related to documentation for the project labels May 22, 2020
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@per1234 per1234 merged commit 8220b32 into arduino:master May 22, 2020
@per1234 per1234 deleted the current-command-docs branch May 22, 2020 09:33
@ArminJo
Copy link

ArminJo commented May 22, 2020

👍 👍 👍

rsora pushed a commit that referenced this pull request May 22, 2020
…dule dependency of docsgen (#719)

Previously, docsgen used a pinned version of the github.com/arduino/arduino-cli module, which resulted in the generated command documentation not reflecting updates to the Arduino CLI command line interface made after the pinned version.

The new approach is to use the current version of the module from the local path, resulting in the generated documentation always matching the associated version of Arduino CLI.

(cherry picked from commit 8220b32)
@per1234 per1234 self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--log-level Debug is documented but not accepted with capital "D"
3 participants