Skip to content

[skip changelog][skip ci] Correct lib name specification re: leading/trailing space #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2020
Merged

[skip changelog][skip ci] Correct lib name specification re: leading/trailing space #779

merged 1 commit into from
Jul 6, 2020

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jul 4, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Remove incorrect prohibition on leading or trailing spaces in the library.properties name field.

  • What is the current behavior?

The library specification includes an unnecessary prohibition against leading or trailing spaces in the library.properties name field.

Leading and trailing space is correctly trimmed on all fields of library.properties, including name.

The unnecessary extra verbosity in the name specification may cause people to miss the other important restrictions.

  • What is the new behavior?

The name specification only contains the true requirements.

  • Does this PR introduce a breaking change?

No.

Sorry, something went wrong.

Leading and trailing space is correctly trimmed on all fields of library.properties, including name.

The unnecessary extra verbosity in the name specification may cause people to miss the other important restrictions.
@per1234 per1234 added the topic: documentation Related to documentation for the project label Jul 4, 2020
@per1234 per1234 merged commit bf4042e into arduino:master Jul 6, 2020
@per1234 per1234 deleted the correct-lib-name-specification branch July 6, 2020 10:48
@per1234 per1234 self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants