Skip to content

The IDE should handle invalid CLI configuration gracefully #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kittaakos opened this issue Aug 27, 2020 · 4 comments
Closed

The IDE should handle invalid CLI configuration gracefully #100

kittaakos opened this issue Aug 27, 2020 · 4 comments
Labels
conclusion: declined Will not be worked on topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

Originally from here: arduino/arduino-pro-ide#310

Start your app with such an invalid config and it hangs:

board_manager:
  additional_urls:
  https://files.seeedstudio.com/arduino/package_seeeduino_boards_index.json
  https://adafruit.github.io/arduino-board-index/package_adafruit_index.json
daemon:
  port: "50051"
directories:
  data: /Users/akos.kitta/Library/Arduino15
  downloads: /Users/akos.kitta/Library/Arduino15/staging
  user: /Users/akos.kitta/Documents/Arduino
logging:
  file: ""
  format: text
  level: info
telemetry:
  addr: :9090
  enabled: true
@ubidefeo
Copy link

this has been addressed by @kittaakos and @silvanocerza in one of the latest iterations of command/config binding between IDE and CLI

@per1234
Copy link
Contributor

per1234 commented Feb 18, 2021

@ubidefeo what results do you get if you put invalid YAML like this in your Arduino Pro IDE arduino-cli.yaml file?:

board_manager:
  additional_urls:
  https://files.seeedstudio.com/arduino/package_seeeduino_boards_index.json
  https://adafruit.github.io/arduino-board-index/package_adafruit_index.json

When I do that, starting Arduino Pro IDE hangs at the splash screen, as reported by Akos.

So it seems to me that this issue has not yet been resolved. Even though it's not so likely to happen now that the Pro IDE's CLI configuration is not so exposed to the user, I still like the idea of making it handle that eventuality gracefully, either by recovering or else communicating about the problem to the user.

@kittaakos kittaakos reopened this Feb 18, 2021
@ubidefeo
Copy link

@per1234
in the case of malformed lists/arrays of additional URLs this should not be an issue because those are filled in using the recently introduced Preferences GUI.
Other settings do require the IDE and the CLI to agree upon

@rsora rsora transferred this issue from arduino/arduino-pro-ide Mar 1, 2021
@cmaglie cmaglie removed the type: bug label Sep 16, 2021
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
@rsora rsora added conclusion: declined Will not be worked on and removed type: imperfection Perceived defect in any part of project labels Oct 25, 2021
@rsora
Copy link
Contributor

rsora commented Oct 25, 2021

CLI settings are hidden since 2.0.0-beta.1 so I'll close this, users are not supposed to enter the CLI config using the settings files anymore.

@rsora rsora added the type: imperfection Perceived defect in any part of project label Oct 25, 2021
@rsora rsora closed this as completed Oct 25, 2021
@per1234 per1234 added the topic: code Related to content of the project itself label Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: declined Will not be worked on topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

6 participants