Skip to content

IDE2 nighty build should show the exact CLI version instead of CLI Version: 0.0.0-git [] #1313

Closed
@kittaakos

Description

@kittaakos

Describe the request

The IDE2 nightly might use a not yet released CLI version. In such a case, the CLI version is CLI Version: 0.0.0-git [] which is not informative when accessed from the About dialog. IDE2 should parse the package.json, get the version object, and show the pinned CLI version instead of 0.0.0-git.

Screen Shot 2022-08-10 at 11 11 28

Describe the current behavior

See description.

Arduino IDE version

Version: 2.0.0-rc9.1-nightly-20220809 Date: 2022-08-09T03:33:26.061Z CLI Version: 0.0.0-git []

Operating system

macOS

Operating system version

13.2.1

Additional context

No response

Issue checklist

  • I searched for previous requests in the issue tracker
    I verified the feature was still missing when using the latest nightly build
    My request contains all necessary details

Activity

self-assigned this
on Aug 10, 2022
per1234

per1234 commented on Aug 10, 2022

@per1234
Contributor

The better resolution would be to use the correct method of building Arduino CLI:

https://arduino.github.io/arduino-cli/dev/CONTRIBUTING/#building-the-source-code

Arduino IDE is currently using an unsupported approach to building Arduino CLI:

if (shell.exec('go build', { cwd: tempRepoPath }).code !== 0) {

The missing version information is fairly innocuous, but it is possible this approach might cause other problems since we assume task build will always be used.

kittaakos

kittaakos commented on Aug 10, 2022

@kittaakos
ContributorAuthor

The better resolution would be to use the correct method of building Arduino CLI:

If IDE2 uses task build instead of go build will the arduino-cli version show that the CLI was created from a fork when it was made from a fork?

per1234

per1234 commented on Aug 10, 2022

@per1234
Contributor

It will only show the short hash:

$ arduino-cli version --format json
{
  "Application": "arduino-cli.exe",
  "VersionString": "git-snapshot",
  "Commit": "869c9711",
  "Status": "",
  "Date": "2022-08-10T09:40:36Z"
}

I think it is sufficient to identify the version in use.

added a commit that references this issue on Aug 10, 2022
bc73751
added 2 commits that reference this issue on Aug 10, 2022
3355220
60e3ebb
added a commit that references this issue on Aug 11, 2022
a39ab47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @kittaakos@per1234

    Issue actions

      IDE2 nighty build should show the exact CLI version instead of `CLI Version: 0.0.0-git []` · Issue #1313 · arduino/arduino-ide