Skip to content

Use require#resolve to locate the plotter app. #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2022
Merged

Use require#resolve to locate the plotter app. #1178

merged 1 commit into from
Jul 13, 2022

Conversation

francescospissu
Copy link
Contributor

Motivation

Avoid to have the serial plotter app twice in the IDE.

Change description

Use require#resolve to locate the plotter app.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@francescospissu francescospissu merged commit afd8bf8 into arduino:fspissu/avoid-twice-serial-plotter-app Jul 13, 2022
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jul 13, 2022
francescospissu added a commit that referenced this pull request Jul 13, 2022
@francescospissu
Avoid twice serial plotter apps (#1174)
c51b201 
* avoid twice serial plotter apps

* remove copy-serial-plotter script.

* Use `require#resolve` to locate the plotter app. (#1178)

Signed-off-by: Akos Kitta <[email protected]>

Co-authored-by: Akos Kitta <[email protected]>

Co-authored-by: Akos Kitta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francescospissu @per1234