Skip to content

fix: flaky compiler test #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2023
Merged

fix: flaky compiler test #1835

merged 1 commit into from
Jan 27, 2023

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Jan 26, 2023 •
edited
Loading

Motivation

To fix the flaky test.

Change description

  • The gRPC core client provider requires an initialized config service when processing the error message received during the InitRequest. The actual fix is here.
  • Additional logging in the config service.
  • The tests log into the console.

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

fix: flaky compiler test
4f8ab72 
 - The gRPC core client provider requires an initialized config service when processing the error message received during the `InitRequest`
 - Additional logging in the config service.
 - The tests log into the console.

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos requested a review from per1234 January 26, 2023 10:09
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Jan 26, 2023
per1234
per1234 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akos!

@kittaakos kittaakos merged commit f5621db into main Jan 27, 2023
@kittaakos kittaakos deleted the fix-flaky-compile-test branch January 27, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees
No one assigned
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kittaakos @per1234