GH-13: Forbid parallel LS-start command execution. #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From now on, a port change won't trigger LS start. Signed-off-by: Akos Kitta <[email protected]>
|
I have fixed the LS start problem. Please review. There is a noteworthy change, the LS won't restart if the FQBN of the selected is the same as it was. For instance, when uploading to the MKR1000 on Windows, the port changes from COM5 to none, then COM6, finally back to COM5. The LS does not restart in such cases. Also, previously one could trigger an LS restart by reselecting the same board; this is not supported anymore. If we need a (force) restart action for whatever reason, we need to implement it as part of a separate task. |
silvanocerza
approved these changes
Feb 18, 2021
rsora
approved these changes
Feb 18, 2021
|
Thank you for the reviews 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From now on, a port change won't trigger LS start.
Closes #13.
Signed-off-by: Akos Kitta [email protected]