arduino · davegarthsimpson · Apr 7, 2025 · Apr 7, 2025 · Apr 7, 2025
diff --git a/arduino-ide-extension/src/common/utils.ts b/arduino-ide-extension/src/common/utils.ts
@@ -38,3 +38,26 @@ export function uint8ArrayToString(uint8Array: Uint8Array): string {
 export function stringToUint8Array(text: string): Uint8Array {
   return Uint8Array.from(text, (char) => char.charCodeAt(0));
 }
+
+export function poolWhile(
+  whileCondition: () => boolean,
+  intervalMs: number,
+  timeoutMs: number
+): Promise<void> {
+  return new Promise((resolve, reject) => {
+    if (!whileCondition) {
+      resolve();
+    }
+
+    const start = Date.now();
+    const interval = setInterval(() => {
+      if (!whileCondition()) {
+        clearInterval(interval);
+        resolve();
+      } else if (Date.now() - start > timeoutMs) {
+        clearInterval(interval);
+        reject(new Error('Timed out while polling.'));
+      }
+    }, intervalMs);
+  });
+}
diff --git a/arduino-ide-extension/src/electron-main/theia/electron-main-application.ts b/arduino-ide-extension/src/electron-main/theia/electron-main-application.ts
@@ -30,6 +30,7 @@ import type { AddressInfo } from 'node:net';
 import { isAbsolute, join, resolve } from 'node:path';
 import type { Argv } from 'yargs';
 import { Sketch } from '../../common/protocol';
+import { poolWhile } from '../../common/utils';
 import {
   AppInfo,
   appInfoPropertyLiterals,
@@ -292,6 +293,16 @@ export class ElectronMainApplication extends TheiaElectronMainApplication {
           );
           if (sketchFolderPath) {
             this.openFilePromise.reject(new InterruptWorkspaceRestoreError());
+
+            // open-file event is triggered before the app is ready and initialWindow is created.
+            // Wait for initialWindow to be set before opening the sketch on the first instance.
+            // See https://github.com/arduino/arduino-ide/pull/2693
+            try {
+              await app.whenReady();
+              if (!this.firstWindowId) {
+                await poolWhile(() => !this.initialWindow, 100, 3000);
+              }
+            } catch {}
             await this.openSketch(sketchFolderPath);
           }
         }
@@ -890,7 +901,10 @@ const fallbackFrontendAppConfig: FrontendApplicationConfig = {
   defaultIconTheme: 'none',
   validatePreferencesSchema: false,
   defaultLocale: '',
-  electron: { showWindowEarly: true, uriScheme: 'custom://arduino-ide' },
+  electron: {
+    showWindowEarly: true,
+    uriScheme: 'arduino-ide',
+  },
   reloadOnReconnect: true,
 };
 

diff --git a/electron-app/package.json b/electron-app/package.json
@@ -67,7 +67,8 @@
         "defaultIconTheme": "none",
         "validatePreferencesSchema": false,
         "electron": {
-          "showWindowEarly": true
+          "showWindowEarly": true,
+          "uriScheme": "arduino-ide"
         },
         "reloadOnReconnect": true,
         "preferences": {

diff --git a/arduino-ide-extension/src/browser/boards/boards-list-widget.ts b/arduino-ide-extension/src/browser/boards/boards-list-widget.ts
        'arduino/board/succesfullyUninstalledPlatform',
        'Successfully uninstalled platform {0}:{1}',
        item.name,
        item.installedVersion!
      ),
      { timeout: 3000 }
    );
diff --git a/arduino-ide-extension/src/browser/contributions/boards-data-menu-updater.ts b/arduino-ide-extension/src/browser/contributions/boards-data-menu-updater.ts
                  unregisterSubmenu(menuPath, this.menuRegistry)
                ),
                ...Array.from(commands.keys()).map((commandId, i) => {
                  const { label } = commands.get(commandId)!;
                  this.menuRegistry.registerMenuAction(menuPath, {
                    commandId,
                    order: String(i).padStart(4),
diff --git a/arduino-ide-extension/src/browser/contributions/edit-contributions.ts b/arduino-ide-extension/src/browser/contributions/edit-contributions.ts
    return undefined;
  }

  protected async run(commandId: string): Promise<any> {
    const editor = await this.current();
    if (editor) {
      const action = editor.getAction(commandId);
diff --git a/arduino-ide-extension/src/browser/contributions/examples.ts b/arduino-ide-extension/src/browser/contributions/examples.ts
        fqbn,
      });
      if (user.length) {
        (user as any).unshift(
          nls.localize(
            'arduino/examples/customLibrary',
            'Examples from Custom Libraries'
        );
      }
      if (name && fqbn && current.length) {
        (current as any).unshift(
          nls.localize('arduino/examples/for', 'Examples for {0}', name)
        );
      }
      if (any.length) {
        (any as any).unshift(
          nls.localize('arduino/examples/forAny', 'Examples for any board')
        );
      }
diff --git a/arduino-ide-extension/src/browser/contributions/include-library.ts b/arduino-ide-extension/src/browser/contributions/include-library.ts
      const userMenuPath = [...includeLibMenuPath, '3_contributed'];
      const { user, rest } = LibraryPackage.groupByLocation(libraries);
      if (rest.length) {
        (rest as any).unshift(
          nls.localize('arduino/library/arduinoLibraries', 'Arduino libraries')
        );
      }
      if (user.length) {
        (user as any).unshift(
          nls.localize(
            'arduino/library/contributedLibraries',
            'Contributed libraries'
diff --git a/arduino-ide-extension/src/browser/contributions/upload-certificate.ts b/arduino-ide-extension/src/browser/contributions/upload-certificate.ts
    });

    registry.registerCommand(UploadCertificate.Commands.OPEN_CERT_CONTEXT, {
      execute: async (args: any) => {
        this.contextMenuRenderer.render({
          menuPath: ArduinoMenus.ROOT_CERTIFICATES__CONTEXT,
          anchor: {
diff --git a/arduino-ide-extension/src/browser/create/create-fs-provider.ts b/arduino-ide-extension/src/browser/create/create-fs-provider.ts
    });
  }

  watch(uri: URI, opts: WatchOptions): Disposable {
    return Disposable.NULL;
  }
	'arduino/board/succesfullyUninstalledPlatform',
	'Successfully uninstalled platform {0}:{1}',
	item.name,
	item.installedVersion!
Check warning on line 86 in arduino-ide-extension/src/browser/boards/boards-list-widget.ts GitHub Actions / check `Forbidden non-null assertion` Check warning on line 86 in arduino-ide-extension/src/browser/boards/boards-list-widget.ts GitHub Actions / check `Forbidden non-null assertion`
	),
	{ timeout: 3000 }
	);
	unregisterSubmenu(menuPath, this.menuRegistry)
	),
	...Array.from(commands.keys()).map((commandId, i) => {
	const { label } = commands.get(commandId)!;
Check warning on line 115 in arduino-ide-extension/src/browser/contributions/boards-data-menu-updater.ts GitHub Actions / check `Forbidden non-null assertion` Check warning on line 115 in arduino-ide-extension/src/browser/contributions/boards-data-menu-updater.ts GitHub Actions / check `Forbidden non-null assertion`
	this.menuRegistry.registerMenuAction(menuPath, {
	commandId,
	order: String(i).padStart(4),
	return undefined;
	}

	protected async run(commandId: string): Promise<any> {
Check warning on line 229 in arduino-ide-extension/src/browser/contributions/edit-contributions.ts GitHub Actions / check `Unexpected any. Specify a different type` Check warning on line 229 in arduino-ide-extension/src/browser/contributions/edit-contributions.ts GitHub Actions / check `Unexpected any. Specify a different type`
	const editor = await this.current();
	if (editor) {
	const action = editor.getAction(commandId);
	fqbn,
	});
	if (user.length) {
	(user as any).unshift(
Check warning on line 329 in arduino-ide-extension/src/browser/contributions/examples.ts GitHub Actions / check `Unexpected any. Specify a different type` Check warning on line 329 in arduino-ide-extension/src/browser/contributions/examples.ts GitHub Actions / check `Unexpected any. Specify a different type`
	nls.localize(
	'arduino/examples/customLibrary',
	'Examples from Custom Libraries'
	);
	}
	if (name && fqbn && current.length) {
	(current as any).unshift(
Check warning on line 337 in arduino-ide-extension/src/browser/contributions/examples.ts GitHub Actions / check `Unexpected any. Specify a different type` Check warning on line 337 in arduino-ide-extension/src/browser/contributions/examples.ts GitHub Actions / check `Unexpected any. Specify a different type`
	nls.localize('arduino/examples/for', 'Examples for {0}', name)
	);
	}
	if (any.length) {
	(any as any).unshift(
Check warning on line 342 in arduino-ide-extension/src/browser/contributions/examples.ts GitHub Actions / check `Unexpected any. Specify a different type` Check warning on line 342 in arduino-ide-extension/src/browser/contributions/examples.ts GitHub Actions / check `Unexpected any. Specify a different type`
	nls.localize('arduino/examples/forAny', 'Examples for any board')
	);
	}
	const userMenuPath = [...includeLibMenuPath, '3_contributed'];
	const { user, rest } = LibraryPackage.groupByLocation(libraries);
	if (rest.length) {
	(rest as any).unshift(
Check warning on line 114 in arduino-ide-extension/src/browser/contributions/include-library.ts GitHub Actions / check `Unexpected any. Specify a different type` Check warning on line 114 in arduino-ide-extension/src/browser/contributions/include-library.ts GitHub Actions / check `Unexpected any. Specify a different type`
	nls.localize('arduino/library/arduinoLibraries', 'Arduino libraries')
	);
	}
	if (user.length) {
	(user as any).unshift(
Check warning on line 119 in arduino-ide-extension/src/browser/contributions/include-library.ts GitHub Actions / check `Unexpected any. Specify a different type` Check warning on line 119 in arduino-ide-extension/src/browser/contributions/include-library.ts GitHub Actions / check `Unexpected any. Specify a different type`
	nls.localize(
	'arduino/library/contributedLibraries',
	'Contributed libraries'
	});

	registry.registerCommand(UploadCertificate.Commands.OPEN_CERT_CONTEXT, {
	execute: async (args: any) => {
Check warning on line 86 in arduino-ide-extension/src/browser/contributions/upload-certificate.ts GitHub Actions / check `Unexpected any. Specify a different type` Check warning on line 86 in arduino-ide-extension/src/browser/contributions/upload-certificate.ts GitHub Actions / check `Unexpected any. Specify a different type`
	this.contextMenuRenderer.render({
	menuPath: ArduinoMenus.ROOT_CERTIFICATES__CONTEXT,
	anchor: {
	});
	}

	watch(uri: URI, opts: WatchOptions): Disposable {
Check warning on line 79 in arduino-ide-extension/src/browser/create/create-fs-provider.ts GitHub Actions / check `'uri' is defined but never used. Allowed unused args must match /^_/u` Check warning on line 79 in arduino-ide-extension/src/browser/create/create-fs-provider.ts GitHub Actions / check `'uri' is defined but never used. Allowed unused args must match /^_/u`
	return Disposable.NULL;
	}