Skip to content
This repository was archived by the owner on Oct 22, 2021. It is now read-only.

Please move the "Outline View" icon and display to the left hand side of the window #354

Closed
paschlie opened this issue Sep 13, 2020 · 11 comments
Labels
type: enhancement New feature or request

Comments

@paschlie
Copy link

paschlie commented Sep 13, 2020

with all the other feature activating/view icons, so its presence won't unnecessarily use screen real estate on the right side of the window.

@paschlie paschlie added the type: enhancement New feature or request label Sep 13, 2020
@paschlie paschlie changed the title Please get rid of the "outline view", as code should be documented in-line; Please move the "Outline View" icon and display to the left hand side icon column of the window Sep 13, 2020
@paschlie paschlie changed the title Please move the "Outline View" icon and display to the left hand side icon column of the window Please move the "Outline View" icon and display to the left hand side of the window Sep 13, 2020
@sstaub
Copy link

sstaub commented Sep 14, 2020

Do it like VSCode please

@kittaakos
Copy link
Contributor

Thanks for letting us know.

For the record: the default, classic layout does not include the Outline view; if you want to gain an additional 50 px, you can right-click on it and select Close.

image

@paschlie
Copy link
Author

paschlie commented Sep 14, 2020

Thanks for letting us know.

For the record: the default, classic layout does not include the Outline view; if you want to gain an additional 50 px, you can right-click on it and select Close.

Thank you, however no such thing appears on macos 10.13.6 right-click (presumably a ctrl-click) to remove the right-hand control icon column, and corresponding outline control icon positioned there, the only thing any type of click on the outline icon does is to toggle the display of the outline pane, which doesn't itself appear to work yet (displaying: No outline information available).

Maybe this is should really be a personal choice, users should be able to decide whether to place icons to enable certain features on the right or left hand columns, and such that if none are placed in one or the other, the space reverts for use by the editor/console sub-windows. But if too complicated, then maybe all control icons should be placed in the left hand icon column, as someone else noted VSCode does; as having both if non-configurable, arguably just takes up space and adds little if any utility.

(As an aside, the minimum window sizes have already been made too large to be properly displayed on smaller screens; saving strictly unnecessary use of window space can only help the situation.)

@kittaakos
Copy link
Contributor

however no such thing appears on macos

Strange, it works for me:

screencast 2020-09-15 09-00-28

@paschlie
Copy link
Author

paschlie commented Sep 15, 2020

Please notice the "outline view" icon is always present without any way to disable it with any key-click combination I can find:
Screen Shot 2020-09-15 at 9 33 40 AM

And when "outline view" is displayed, it does not contain anything useful on my installation, and never noticed it ever doing so?:
Screen Shot 2020-09-15 at 9 33 57 AM

@kittaakos
Copy link
Contributor

And when "outline view" is displayed, it does not contain anything useful on my installation, and never noticed it ever doing so?:

You have to pick a board to start the language server and have the Outline view populated. (See the specification for 'textDocument/documentSymbol' here if you're interested.)

@paschlie
Copy link
Author

paschlie commented Sep 15, 2020

Selecting a board doesn't seem to make any difference, but if significant here are the messages present after selecting the board (and not sure why it should make a difference, but why can't the "outline view" icon and corresponding right-hand icon column be dismissed, does it somehow rely on "outline-view" working properly? And the bottom of my window is still cut off as it's minimum dimensions are larger than the screen):
Screen Shot 2020-09-15 at 9 50 42 AM

@paschlie
Copy link
Author

2020-09-15_log.log

@kittaakos
Copy link
Contributor

so its presence won't unnecessarily use screen real estate on the right side of the window.

Do it like VSCode please

Thank you for your feedback; I moved it to the left side.

Classic mode:
354_classic_mode

Advanced mode:
354_advanced

The change will be available with one of the nightly builds this week or next week.

@paschlie
Copy link
Author

paschlie commented Sep 16, 2020 via email

@kittaakos
Copy link
Contributor

Has this change been published in the nightly build? (I didn’t notice any change log entry?)

No, not yet. 👇

The change will be available with one of the nightly builds this week or next week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants