Skip to content

Handle inappropriate null output from arduino-cli core list when no platforms are installed #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Handle inappropriate null output from arduino-cli core list when no platforms are installed #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions compilesketches/compilesketches.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1453,6 +1453,11 @@ def cli_core_list_platform_list(self, data):
or semver.Version.parse(version=self.cli_version).compare(other=first_new_interface_version) >= 0
):
# cli_version is either "latest" (which will now always be >=1.0.0) or an explicit version >=1.0.0

# Workaround for https://github.com/arduino/arduino-cli/issues/2690
if data["platforms"] is None:
return []

return data["platforms"]

return data
Expand Down
1 change: 1 addition & 0 deletions compilesketches/tests/test_compilesketches.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2886,6 +2886,7 @@ def test_create_sketches_report_file(monkeypatch, tmp_path):
@pytest.mark.parametrize(
"cli_version, data, assertion",
[
("latest", {"platforms": None}, []), # Non-semver
("latest", {"platforms": [unittest.mock.sentinel.list_item]}, [unittest.mock.sentinel.list_item]), # Non-semver
("2.0.0", {"platforms": [unittest.mock.sentinel.list_item]}, [unittest.mock.sentinel.list_item]), # >
("1.0.0", {"platforms": [unittest.mock.sentinel.list_item]}, [unittest.mock.sentinel.list_item]), # ==
Expand Down
Loading