Skip to content

PORTENTA_H7: CYW4343X support and BLE low power implementation #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

pennam
Copy link

@pennam pennam commented Oct 6, 2020

Summary of changes

  1. COMPONENT_CYW4343X make transport layer generic.
  2. BLE low power implementation for PORTENTA board.

Impact of changes

All boards using COMPONENT_CYW4343X

Migration actions required

Documentation


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@pennam pennam changed the title PORTENTA_H7 BLE low power implementation PORTENTA_H7: BLE low power implementation Oct 6, 2020
@pennam pennam force-pushed the patch-portenta-ble branch 2 times, most recently from 17b2fd7 to 7c30dfa Compare October 12, 2020 09:35
@pennam pennam marked this pull request as ready for review October 12, 2020 10:18
@pennam pennam marked this pull request as draft October 12, 2020 14:12
@pennam pennam force-pushed the patch-portenta-ble branch from 7c30dfa to 33d7047 Compare October 13, 2020 14:34
@pennam

This comment has been minimized.

@pennam pennam marked this pull request as ready for review October 13, 2020 15:06
@pennam pennam changed the title PORTENTA_H7: BLE low power implementation PORTENTA_H7: CYW4343X support and BLE low power implementation Oct 13, 2020
@pennam pennam force-pushed the patch-portenta-ble branch from d967edb to a13c5d1 Compare January 11, 2021 11:20
@pennam
Copy link
Author

pennam commented Jan 11, 2021

@facchinm @polldo i need some advice about 3a38556 and cca4043. They are not needed anymore?

@facchinm
Copy link
Member

So, we need to retest on nano33ble, but cca4043 should be dropped (it's harmful in the latest versions of Cordio).
3a38556 is a bit more complicated since it is needed by some v3 boards (which are actively being sold). It's not needed for sure on v4, so I'd keep in out "extrapatches" when building the core but avoid filing it mainline.

@pennam
Copy link
Author

pennam commented Jan 18, 2021

On my v3 board 3a38556 is not needed but without 6378d88 BLE is not working.
For portenta boards i would keep this pr as is plus 3a38556 and 6378d88 as BLE "extrapatches"

@pennam pennam force-pushed the patch-portenta-ble branch from a13c5d1 to 80d2873 Compare January 19, 2021 09:57
@pennam
Copy link
Author

pennam commented Jan 25, 2021

@facchinm i was submitting the pr but then i tought that cypress would not be happy to lose cyhal support, so i've made some changes here pennam@2db301c. What do you think about it? I don't like it too much, but it will preserve cyhal support for cypress targets and the possibility to use uart for all the others.

@pennam
Copy link
Author

pennam commented Mar 11, 2021

Mainlined as ARMmbed#14227 and ARMmbed#14420

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ facchinm
❌ 0xc0170
❌ rajkan01
You have signed the CLA already but the status is still pending? Let us recheck it.

@pennam pennam closed this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants