Skip to content

STM32: Compute I2C timing according current I2C clock source and required I2C clock #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 506 commits into from

Conversation

pennam
Copy link

@pennam pennam commented Oct 6, 2020

Summary of changes

Compute I2C timing register according I2C clock source (APB1CLK) and required I2C clock frequency

Impact of changes

STM32H7 family

Migration actions required

Documentation


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@pennam pennam force-pushed the patch-portenta-i2c branch 2 times, most recently from cc9c716 to 503d7df Compare October 12, 2020 10:20
@pennam pennam marked this pull request as ready for review October 27, 2020 14:28
@pennam pennam marked this pull request as draft October 27, 2020 14:34
0xc0170 and others added 26 commits November 3, 2020 14:01
copyright date change
Including unused header file, "cmsis-os.h",  causes compile errors.
This commit fixes it.

Signed-off-by: Heuisam Kwag <[email protected]>
Add function "has_binary_license" to check if a file has a non-permissive license contains one. PBL is not recognized by scancode,
causing it to be flagged as a non-permissive license. CI doesn't allow
any non-permissive licenses, although, files flageed as SPDX are
allowed. Workaround causes all files with a valid PBL to be flagged as
missing an SPDX.

Add condition in "has_spdx_text_in_scancode_output" to ignore any spdx
identifier with "unknown" in the name. Scancode erroneously matches PBL to matched_rule.identifer "spdx-license-identifier: unknown-spdx". This prevents the workaround from working.
Impact all STM32L4x5 and STM32L4x6 targets
…y-bytes

Fix SPIF read dummy cycles not being reset
Add critical section in
- flash_erase_sector and
- flash_program_page
to make FLASH erase procedure interrupt safe
(can occur with Ethernet)
SCL is for the Cypress Ethernet driver which is not currently
compatible with bare metal.
Add function "has_binary_license" to check if a file has a
non-permissive license contains one. PBL is not recognized by scancode,
causing it to be flagged as a non-permissive license. CI doesn't allow
any non-permissive licenses, although, files flageed as SPDX are
allowed. Workaround causes all files with a valid PBL to be flagged as
missing an SPDX.

Add condition in "has_spdx_text_in_scancode_output" to ignore any spdx
identifier with "unknown" in the name. Scancode erroneously matches PBL
to matched_rule.identifer "spdx-license-identifier: unknown-spdx". This
prevents the workaround from working.
@pennam pennam force-pushed the patch-portenta-i2c branch from 503d7df to dc0c23e Compare November 16, 2020 11:08
@pennam pennam changed the title STM32: allow overriding APB1CLK for I2C timings STM32: Compute I2C timing according current I2C clock source and required I2C clock Nov 16, 2020
@pennam pennam force-pushed the patch-portenta-i2c branch from dc0c23e to 93a666d Compare November 30, 2020 11:07
@pennam pennam force-pushed the patch-portenta-i2c branch from 93a666d to 5971e7e Compare November 30, 2020 11:19
@pennam pennam marked this pull request as ready for review November 30, 2020 11:21
@pennam
Copy link
Author

pennam commented Nov 30, 2020

waveform @ 100Khz
i2c_100khz_cursor
waveform @1000Khz
i2c_1000Khz_cursor

@pennam
Copy link
Author

pennam commented Mar 11, 2021

Mainlined and merged as ARMmbed#14030

@pennam pennam closed this Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.