Skip to content

Made this repo a library #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jul 19, 2021
Merged

Made this repo a library #1

merged 20 commits into from
Jul 19, 2021

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jul 16, 2021

So most of this code can be reused as a reference implementation.

@cmaglie cmaglie requested a review from silvanocerza July 16, 2021 13:08
silvanocerza
silvanocerza reviewed Jul 19, 2021
View reviewed changes
silvanocerza
silvanocerza reviewed Jul 19, 2021
View reviewed changes
silvanocerza
silvanocerza reviewed Jul 19, 2021
View reviewed changes
silvanocerza
silvanocerza reviewed Jul 19, 2021
View reviewed changes
@cmaglie cmaglie merged commit f60f4a9 into main Jul 19, 2021
@cmaglie cmaglie deleted the extract_as_lib branch July 19, 2021 14:43
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@silvanocerza silvanocerza silvanocerza approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmaglie @silvanocerza @per1234