Skip to content

Add CI workflow to lint and check formatting of Go code #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2022
Merged

Add CI workflow to lint and check formatting of Go code #25

merged 1 commit into from
Jul 28, 2022

Conversation

MatteoPologruto
Copy link
Contributor

On every push and pull request that affects relevant files, check the repository's Go module for:

  • Common detectable errors in the code.
  • Use of outdated APIs
  • Code style violations
  • Code formatting inconsistency
  • Misconfiguration

@MatteoPologruto MatteoPologruto requested a review from umbynos July 28, 2022 10:30
@CLAassistant
Copy link

CLAassistant commented Jul 28, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@MatteoPologruto MatteoPologruto requested a review from per1234 July 28, 2022 10:31
@MatteoPologruto
Copy link
Contributor Author

I'll fix the Check Go errors in another PR, then rebase this one.

umbynos
umbynos suggested changes Jul 28, 2022
View reviewed changes
@MatteoPologruto MatteoPologruto requested a review from umbynos July 28, 2022 15:25
@MatteoPologruto
Add CI workflow to lint and check formatting of Go code
605d202 
On every push and pull request that affects relevant files, check the Go module for:

- Common detectable errors in the code.
- Use of outdated APIs
- Code style violations
- Code formatting inconsistency
- Misconfiguration
umbynos
umbynos approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 🏁

@MatteoPologruto MatteoPologruto merged commit 4782fee into master Jul 28, 2022
@MatteoPologruto MatteoPologruto deleted the check-go-task branch July 28, 2022 15:52
@umbynos umbynos mentioned this pull request Jul 28, 2022
Closed
@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Jul 31, 2022
@MatteoPologruto MatteoPologruto self-assigned this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umbynos umbynos umbynos approved these changes

@per1234 per1234 Awaiting requested review from per1234

Assignees

@MatteoPologruto MatteoPologruto

Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MatteoPologruto @CLAassistant @umbynos @per1234