bump k8s v1.33 and remove all replaces #717
Conversation
|
We should start from migration of golangci-lint |
|
On it: #719 |
Signed-off-by: sivchari <[email protected]>
|
Thx! rebsaed. |
…t is not necessary anymore Signed-off-by: sivchari <[email protected]>
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #717 +/- ##
==========================================
- Coverage 54.26% 47.57% -6.70%
==========================================
Files 64 63 -1
Lines 6164 6443 +279
==========================================
- Hits 3345 3065 -280
- Misses 2549 3125 +576
+ Partials 270 253 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -905,25 +907,26 @@ func normalizeEndpoint(un *unstructured.Unstructured, o options) { | |||
| if gvk.Group != "" || gvk.Kind != "Endpoints" { | |||
| return | |||
| } | |||
| var ep corev1.Endpoints | |||
| var ep discoveryv1.EndpointSlice | |||
There was a problem hiding this comment.
I don't understand this change... the code seems to be specific to normalization of endpoints, not endpoint slices.
There was a problem hiding this comment.
Since v1.33 corev1.Endpoints is deprecated, then it recommends us to use discoveryv1.EndpointSlice, so I replaced it. Should we ignore the lint error ?
There was a problem hiding this comment.
Interesting... yep, probably should ignore the lint error. I'm not sure if EndpointSlices have similar diff issues that require normalization. But for now we should just preserve the Endpoint normalization logic and wait to see if bugs are reported for EndpointSlices.
|
Can you describe what go/k8s behavior made the replaces no longer necessary? I'm not sure I understand why they were ever necessary, but would love to be able to get rid of them. :-) |
Upgrade Kubernetes dependency to 1.33, then delete all replace directives since it's no necessary. If we use lower kubernetes dependency in other repo and depends on gitops-engine, Go prefers dependency of gitops-engine. On the other hand, if we use higher it, Go prefers dependency of other repo. In addition, the number of dependencies from gitops-engine to Kubernetes is a few, so it's easy to maintain rather than to deal with replace directive.
If necessary, I'd like to maintain about it in the future too.