Skip to content

Conversation

sky-coderay
Copy link
Contributor

No description provided.

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@r0qs
Copy link
Member

r0qs commented Jan 20, 2025

@r0qs r0qs changed the title fix AssemblyItem.cpp Fix RETURNCONTRACT instruction for EOF Assembly Item Jan 20, 2025
@r0qs r0qs requested a review from cameel January 20, 2025 11:42
@r0qs r0qs added the EOF label Jan 20, 2025
@r0qs
Copy link
Member

r0qs commented Jan 20, 2025

I took the liberty of updating the test expectations for you. Also, a changelog entry is not necessary, as this bug only affects EOF code generation.

@cameel cameel changed the title Fix RETURNCONTRACT instruction for EOF Assembly Item Fix the name of RETURNCONTRACT instruction in EOF assembly output Jan 20, 2025
@cameel
Copy link
Collaborator

cameel commented Jan 20, 2025

Good find. Since the compiler does not support importing this assembly form (only JSON), we never really test if it's well formed and if the names match the instructions. I wonder if we have more bugs like this hiding there.

@r0qs r0qs merged commit d750b9d into argotorg:develop Jan 20, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants