Skip to content

chore: Update to Rust 1.88 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 0 additions & 49 deletions .cargo/config

This file was deleted.

16 changes: 14 additions & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,29 @@ updates:
separator: "-"
schedule:
interval: weekly
# Create separate pull requests for major vs minor/patch version updates, as major bumps will likely introduce breaking changes
groups:
rust-dependencies:
rust-minor:
patterns:
- "*"
update-types:
- "minor"
- "patch"

rust-major:
patterns:
- "*"
update-types:
- "major"
allow:
# Update both direct and indirect dependencies
- dependency-type: "all"
open-pull-requests-limit: 5

- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
groups:
actions:
patterns:
- "*"
47 changes: 29 additions & 18 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ name: Build and Test
on:
merge_group:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
branches:
- main
- dev
- 'feat/**'
- release-candidate
workflow_dispatch:
Expand All @@ -16,33 +16,44 @@ concurrency:

jobs:
linux-test:
# Change to buildjet-16vcpu-ubuntu-2204 for a more powerful runner (GitHub App must be enabled)
# Change to warp-ubuntu-latest-x64-16x for a more powerful runner (GitHub App must be enabled for this repo)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
repository: lurk-lab/ci-workflows
repository: argumentcomputer/ci-workflows
- uses: ./.github/actions/ci-env
- uses: actions/checkout@v4
with:
submodules: recursive
- uses: dtolnay/rust-toolchain@stable
- uses: taiki-e/install-action@nextest
- uses: Swatinem/rust-cache@v2
- name: Linux Tests
run: |
cargo nextest run --profile ci --cargo-profile dev-ci --workspace

# Wasm build, rustfmt, clippy, doctests, and MSRV
code-quality:
uses: lurk-lab/ci-workflows/.github/workflows/lints.yml@main

# Check documentation links aren't broken
link-checker:
uses: lurk-lab/ci-workflows/.github/workflows/links-check.yml@main
with:
fail-fast: true

# Lint dependencies for licensing and auditing issues as per `deny.toml`
licenses-audits:
uses: lurk-lab/ci-workflows/.github/workflows/licenses-audits.yml@main
lints:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
repository: argumentcomputer/ci-workflows
- uses: ./.github/actions/ci-env
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- name: Check Rustfmt code style
run: cargo fmt --all --check
- name: Check *everything* compiles
run: cargo check --all-targets --all-features --workspace
- name: Check clippy lints
run: cargo clippy --workspace --all-targets -- -D warnings
- name: Doctests
run: cargo test --doc --workspace
- name: Get Rust version
run: |
echo "RUST_VERSION=$(awk -F '"' '/^channel/ {print $2}' rust-toolchain.toml)" | tee -a $GITHUB_ENV
# Lint dependencies for licensing and auditing issues as per `deny.toml`
- name: Cargo-deny
uses: EmbarkStudios/cargo-deny-action@v2
with:
rust-version: ${{ env.RUST_VERSION }}
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ on:

jobs:
docs:
uses: lurk-lab/ci-workflows/.github/workflows/docs.yml@main
uses: argumentcomputer/ci-workflows/.github/workflows/docs.yml@main
6 changes: 3 additions & 3 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ env:

jobs:
unused-dependencies:
uses: lurk-lab/ci-workflows/.github/workflows/unused-deps.yml@main
uses: argumentcomputer/ci-workflows/.github/workflows/unused-deps.yml@main

rust-version-check:
uses: lurk-lab/ci-workflows/.github/workflows/rust-version-check.yml@main
uses: argumentcomputer/ci-workflows/.github/workflows/rust-version-check.yml@main

typos:
uses: lurk-lab/ci-workflows/.github/workflows/typos.yml@main
uses: argumentcomputer/ci-workflows/.github/workflows/typos.yml@main
4 changes: 0 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@
debug/
target/

# Remove Cargo.lock from gitignore if creating an executable, leave it for libraries
# More information here https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
Cargo.lock

# These are backup files generated by rustfmt
**/*.rs.bk

Expand Down
2 changes: 1 addition & 1 deletion CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ representative at an online or offline event.
## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported to the community leaders responsible for enforcement at community@lurk-lab.com.
reported to the community leaders responsible for enforcement at community@argument.xyz.
All complaints will be reviewed and investigated promptly and fairly.

All community leaders are obligated to respect the privacy and security of the
Expand Down
7 changes: 7 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

50 changes: 47 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
[package]
name = "template"
version = "0.1.0"
edition = "2021"
authors = ["Lurk Lab Engineering <engineering@lurk-lab.com>"]
edition = "2024"
authors = ["Argument Engineering <engineering@argument.xyz>"]
license = "MIT OR Apache-2.0"
# EDIT AS NEEDED
rust-version = "1.70"
rust-version = "1.88"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

Expand All @@ -22,3 +22,47 @@ opt-level = 3
lto = "thin"
incremental = false
codegen-units = 16

[lints.clippy]
cast_lossless = "warn"
cast_possible_truncation = "warn"
cast_precision_loss = "warn"
cast_sign_loss = "warn"
cast_possible_wrap = "warn"
ptr_as_ptr = "warn"
checked_conversions = "warn"
dbg_macro = "warn"
derive_partial_eq_without_eq = "warn"
enum_glob_use = "warn"
explicit_into_iter_loop = "warn"
fallible_impl_from = "warn"
filter_map_next = "warn"
flat_map_option = "warn"
from_iter_instead_of_collect = "warn"
implicit_clone = "warn"
inefficient_to_string = "warn"
large_stack_arrays = "warn"
large_types_passed_by_value = "warn"
macro_use_imports = "warn"
manual_assert = "warn"
map_err_ignore = "warn"
map_unwrap_or = "warn"
match_same_arms = "warn"
match_wild_err_arm = "warn"
needless_continue = "warn"
needless_for_each = "warn"
needless_pass_by_value = "warn"
option_option = "warn"
same_functions_in_if_condition = "warn"
trait_duplication_in_bounds = "warn"
unnecessary_wraps = "warn"
unnested_or_patterns = "warn"
use_self = "warn"

[lints.rust]
nonstandard_style = "warn"
rust_2024_compatibility = "warn"
trivial_numeric_casts = "warn"
unused_lifetimes = "warn"
unused_qualifications = "warn"
unreachable_pub = "warn"
2 changes: 1 addition & 1 deletion LICENSE-MIT
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
MIT License

Copyright (c) 2024 Lurk Lab
Copyright (c) 2025 Argument Computer Corporation

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
# template-rust-lib
Base template for a Rust library crate with CI, config files, and branch protection

Base template for a Rust library with CI, config files, and branch protection

## Usage
- Generate a new repo via the green "Use this template" button
- Run the following to remove template language:
```
# Replace all occurrences with the desired library name
$ grep -ir template . --exclude-dir .git --exclude deny.toml
# Replace all occurrences as needed
$ grep -r "EDIT AS NEEDED" .
$ rg -i template --glob '!deny.toml'
# Update Rust toolchain if desired
$ rg "EDIT AS NEEDED"
# Then rewrite this `README`
```
- Create a branch protection rule for `main` and enable the following as needed:
Expand All @@ -17,10 +18,9 @@ $ grep -r "EDIT AS NEEDED" .
- Dismiss stale pull request approvals when new commits are pushed
- Require approval of the most recent reviewable push
- Require status checks to pass before merging (optional, after CI has been triggered)
- E.g. `linux-test`, `msrv`, and `lints`
- E.g. `linux-test` and `lints`
- Require a merge queue using `squash and merge` (optional, only allowed if repo is public)
- Allow force pushes if needed to bypass above restrictions when necessary
- Enable full write access for Lurk Lab members by adding the `lurk-dev` team in `Settings->Collaborators and teams`
- Edit licenses and `deny.toml` as needed

## License
Expand Down
Loading
Loading