fix on osc/mt_v4 #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artpol84
requested changes
Nov 30, 2018
| OPAL_DECLSPEC void | ||
| opal_common_ucx_req_completion(void *request, ucs_status_t status) { | ||
| opal_common_ucx_request_t *req = (opal_common_ucx_request_t *)request; | ||
| ucp_request_release(req); |
There was a problem hiding this comment.
if( request->user_cb != NULL ){
call it
}
| @@ -105,9 +105,14 @@ typedef enum { | |||
| OPAL_COMMON_UCX_MEM_MAP | |||
| } opal_common_ucx_mem_type_t; | |||
|
|
|||
| typedef struct { | |||
| void *external_req; | |||
There was a problem hiding this comment.
Add:
- user callback
- winfo ptr is to be added in subsequent commit introducing fine-grained locking
| buffer, len, | ||
| rem_addr, rkey, | ||
| winfo->worker); | ||
| (*ptr) = ucp_atomic_fetch_nb(ep, opcode, value, buffer, len, |
There was a problem hiding this comment.
Add the new parameter to opal_common_ucx_atomic_fetch_nb with the completion handler.
xinzhao3
force-pushed
the
osc/mt_v4
branch
3 times, most recently
from
3bb19c4 to
d4605fb
Compare
artpol84
requested changes
Dec 1, 2018
opal/mca/common/ucx/common_ucx_int.h
Outdated
| @@ -170,10 +171,11 @@ static inline | |||
| ucs_status_ptr_t opal_common_ucx_atomic_fetch_nb(ucp_ep_h ep, ucp_atomic_fetch_op_t opcode, | |||
| uint64_t value, void *result, size_t op_size, | |||
| uint64_t remote_addr, ucp_rkey_h rkey, | |||
| opal_common_ucx_user_req_handler_t req_handler, | |||
| #include "opal_config.h" | ||
| #include <ucp/api/ucp.h> | ||
|
|
||
| typedef void (*opal_common_ucx_req_handler_t)(void *request, ucs_status_t status); |
There was a problem hiding this comment.
Fix here to not expose common internals
| int target, void *buffer, size_t len, | ||
| uint64_t rem_addr, | ||
| opal_common_ucx_user_req_handler_t user_req_cb, | ||
| void *user_req_ptr, int *completed) |
There was a problem hiding this comment.
don't need completed flag. Call the callback instead.
| 0, target, &(module->req_result), | ||
| sizeof(uint64_t), remote_addr, | ||
| (ucs_status_ptr_t *)&internal_req); | ||
| 0, target, &(module->req_result), |
There was a problem hiding this comment.
increment the counters before calling this. Otherwise may go negative.
| opal_mutex_unlock(&winfo->mutex); | ||
|
|
||
| if (UCS_PTR_IS_PTR(req)) { |
xinzhao3
force-pushed
the
osc/mt_v4
branch
4 times, most recently
from
14371b0 to
dfc5a39
Compare
artpol84
approved these changes
Dec 1, 2018
|
@xinzhao3 More important is that we need a sign-off in each commit. And I don't see them here. |
Signed-off-by: Xin Zhao <[email protected]>
Signed-off-by: Xin Zhao <[email protected]>
Signed-off-by: Xin Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.