Osc/mt v4 tmp #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artpol84
requested changes
Dec 5, 2018
| @@ -1228,22 +1228,25 @@ opal_common_ucx_tlocal_fetch_spath(opal_common_ucx_wpmem_t *mem, int target) | |||
| } | |||
|
|
|||
| OPAL_DECLSPEC int | |||
| opal_common_ucx_flush(ucp_ep_h ep, ucp_worker_h worker, | |||
| opal_common_ucx_flush(opal_common_ucx_winfo_t *winfo, int target, | |||
There was a problem hiding this comment.
change the name to opal_common_ucx_winfo_flush to indicate that it is specific for wpool.
| } | ||
| ctr--; | ||
| } while (ctr > 0 && ret > 0); | ||
| opal_mutex_unlock(&winfo->mutex); |
| if (status != UCS_INPROGRESS) { | ||
| ucp_request_free(request); | ||
| if (OPAL_LIKELY(UCS_OK == status)) { | ||
| return OPAL_SUCCESS; |
| msg ? msg : __func__, | ||
| UCS_PTR_STATUS(request), | ||
| ucs_status_string(UCS_PTR_STATUS(request))); | ||
| return OPAL_ERROR; |
| break; | ||
| } | ||
| ctr--; | ||
| } while (ctr > 0 && ret > 0); |
xinzhao3
force-pushed
the
osc/mt_v4_tmp
branch
from
b9e0005 to
6803668
Compare
|
@artpol84 could you review again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.