Skip to content

raise error if the constraint is created on a field that doesn't exist #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xantrac
Copy link

@xantrac xantrac commented Jun 30, 2025

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@zachdaniel
Copy link
Contributor

Thanks for the PR! I think this behavior is valuable but would be better placed in a verifier on the data layer extension. This will give errors at compile time instead of when generating migrations. See this verifier for example: https://github.com/ash-project/ash_postgres/blob/main/lib/verifiers/validate_identity_index_names.ex

@xantrac
Copy link
Author

xantrac commented Jun 30, 2025

Thanks for the PR! I think this behavior is valuable but would be better placed in a verifier on the data layer extension. This will give errors at compile time instead of when generating migrations. See this verifier for example: https://github.com/ash-project/ash_postgres/blob/main/lib/verifiers/validate_identity_index_names.ex

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants