More Arc to AggregateFunctionExpr
#1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a benchmark aimed at tracking inefficiencies at the stage of creating/optimizing a physical plan.
Patch f5c47fa removed Arc wrappers for AggregateFunctionExpr. But, it can be inefficient. When physical optimizer decides to replace a node child to other, it clones the node (with `with_new_children`). Assume, that node is `AggregateExec` than contains hundreds aggregates and these aggregates are cloned each time. This patch returns a Arc wrapping to not clone AggregateFunctionExpr itself but clone a pointer.
This patch adds a small optimization that can soft the edges on some queries. If there are no parent requirements we do not need to build column mapping.
alamb
commented
Oct 17, 2024
|
|
||
| AggregateExprBuilder::new(Arc::new(updated_fn), self.args.to_vec()) | ||
| .order_by(self.ordering_req.to_vec()) | ||
| .schema(Arc::new(self.schema.clone())) |
There was a problem hiding this comment.
In particular, I believe this is a deep clone
alamb
commented
Oct 17, 2024
| ) -> Result<Option<AggregateFunctionExpr>> { | ||
| let Some(updated_fn) = self | ||
| .fun | ||
| .clone() |
askalt
force-pushed
the
askalt/plan-creaton-perf-improvements
branch
from
9d2d031 to
fdb0b33
Compare
|
Will create a PR to DataFusion main instead |
Ok, thank you, I was busy yesterday, I didn't have time to merge it :(. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets apache#12950
This is a proposal to add even more
Arcto theAggregateFunctionExprin order to reduce more deep clones