This repository was archived by the owner on Jan 20, 2025. It is now read-only.
Include normal reset byte in test assertion #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test for coloured output will fail due to a mismatch between what is generated and what is asserted. The generated output will contain a byte to set console output to normal before subsequently modifying it to be coloured red at normal intensity. Update the assertion to match.
|
Appears this was caused by a PR being merged recently in mgutz/ansi#11, possibly with the change in #50 it would be possible to pin to a specific git sha using go.mod to prevent this in the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for coloured output will fail due to a mismatch between what is
generated and what is asserted. The generated output will contain a byte
to set console output to normal before subsequently modifying it to be
coloured red at normal intensity. Update the assertion to match.