Parse and bind to IP's configured via --server.urls #168
Conversation
halter73
force-pushed
the
halter73/parse-ip
branch
from
5e493d7 to
12cd3ec
Compare
- Will revisit when aspnet/KestrelHttpServer#1290 is addressed
halter73
force-pushed
the
halter73/parse-ip
branch
from
12cd3ec to
2dfdb74
Compare
|
|
||
| if (string.Equals(uri.Host, "localhost", StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| ip = IPAddress.Loopback; |
There was a problem hiding this comment.
Technically I think we should bind to both IPAddress.Loopback and IPAddress.IPv6Loopback, like we do at https://github.com/aspnet/KestrelHttpServer/blob/2351c1b558fc6f4312af262aa866fd2c5164761f/src/Microsoft.AspNetCore.Server.Kestrel/KestrelServer.cs#L230.
There was a problem hiding this comment.
What if the port is also 0? Do we add logic to throw in that case like we do Kestrel? It also complicates things slightly (but not too much) to have multiple IPEndpoints per URL.
In practice IPv4 loopback always seems to work when "localhost" is specified, but I'll change it if it's important
There was a problem hiding this comment.
What you have now should be sufficient to unblock most scenarios. We should revisit this after the final design though.
is addressed
@mikeharder