Skip to content

Update Microsoft.Azure.KeyVault version to 2.2.1-preview #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

JunTaoLuo
Copy link
Contributor

This version is being verified by @pakrym now. Once verified and pushed to nuget we can update this version in Configuration.AzureKeyVault.

This will fix the issue Azure/azure-sdk-for-net#3003 and will unblock aspnet/MetaPackages#21 where we want to include this in the metapackage and runtime store.

@JunTaoLuo JunTaoLuo requested review from Eilon, pakrym and muratg May 3, 2017 17:46
@dnfclas
Copy link

dnfclas commented May 3, 2017

@JunTaoLuo,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Copy link

@muratg muratg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update the sample to have both JSON and KeyVault? (To prevent regressions with version caps in the future.)

@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented May 3, 2017

@pakrym found another problem where one of the transitive dependencies of M.Azure.KeyVault, Microsoft.Rest.ClientRuntime 2.3.6 also restricts the version of Newtonsoft.Json to less than 10. We may not be able to make this change.

@muratg We can do that to prevent this specific regression but do we then plan on doing this for every third party dependency everywhere in our code base?

@JunTaoLuo JunTaoLuo changed the title Update Microsoft.Azure.KeyVault version to 2.2.1-preview1 Update Microsoft.Azure.KeyVault version to 2.2.1-preview May 3, 2017
@JunTaoLuo JunTaoLuo closed this May 5, 2017
@JunTaoLuo JunTaoLuo force-pushed the johluo/keyvault-update branch from ed79522 to 5b4ff0e Compare May 5, 2017 18:32
@JunTaoLuo JunTaoLuo deleted the johluo/keyvault-update branch May 5, 2017 18:32
@JunTaoLuo
Copy link
Contributor Author

Merged in 5b4ff0e

@th3morg
Copy link

th3morg commented Feb 7, 2018

This should be reopened. The issue is happening again in the latest build.

@Eilon
Copy link
Contributor

Eilon commented Feb 7, 2018

@th3morg can you log a new issue with details of what's happening? Please include any relevant version details, logs, error messages, stack traces, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants